Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install file and not absolute path #110

Merged
merged 1 commit into from Sep 25, 2017
Merged

Conversation

mikaelarguedas
Copy link
Contributor

Follow-up of #103.
Absolute path of the module file is appended to the install path resulting in errors such as:
Can't list '/home/rosbuild/ci_scripts/ws/install/lib/python3.5/site-packages/builtin_interfaces//home/rosbuild/ci_scripts/ws/build/builtin_interfaces/rosidl_generator_py/builtin_interfaces/__init__.py' in console output of any job since this job. This PR passes only the module name resulting in a correct installation path for the module file.

@mikaelarguedas mikaelarguedas self-assigned this Sep 25, 2017
@mikaelarguedas mikaelarguedas added the in progress Actively being worked on (Kanban column) label Sep 25, 2017
@mikaelarguedas
Copy link
Contributor Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
    (test failures urelated)

@mikaelarguedas mikaelarguedas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Sep 25, 2017
Copy link
Contributor

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikaelarguedas mikaelarguedas merged commit dcc2a70 into master Sep 25, 2017
@mikaelarguedas mikaelarguedas removed the in review Waiting for review (Kanban column) label Sep 25, 2017
@mikaelarguedas mikaelarguedas deleted the fix_python_install branch September 25, 2017 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants