Use errors attribute for problems when testing code (take II) #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to treat the warnings differently in downstream packages. Refer to the CMake documentation for more info: https://cmake.org/cmake/help/v3.0/command/message.html Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
dirk-thomas
reviewed
May 7, 2020
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
|
For testing: I've created a segfault test in rclcpp time and run together with this change: https://ci.ros2.org/job/ci_linux/10916. Console log: Reported as usual in the test list: https://ci.ros2.org/job/ci_linux/10916/testReport/junit/(root)/projectroot/test_time/. I don't see any other side effect in the rest of reports. |
dirk-thomas
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion in #225 (comment), the PR changes the use of failures attribute to errors to report problems with testing code (note the difference with the usual failing tests).
rework of #228
Testing using packages up to rclcpp