Fix parallel testing #254
Merged
Fix parallel testing #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We ran ctest . -j 10, and sometimes it happened that we got failing CI builds because the command in line 116 was executed in parallel. ``` [2020-04-28T19:13:39.193Z] 1: Traceback (most recent call last): [2020-04-28T19:13:39.193Z] 1: File "/opt/ros/eloquent/share/ament_cmake_test/cmake/run_test.py", line 23, in <module> [2020-04-28T19:13:39.193Z] 1: sys.exit(ament_cmake_test.main()) [2020-04-28T19:13:39.193Z] 1: File "/opt/ros/eloquent/lib/python3.6/site-packages/ament_cmake_test/__init__.py", line 116, in main [2020-04-28T19:13:39.193Z] 1: os.makedirs(output_path) [2020-04-28T19:13:39.193Z] 1: File "/usr/lib/python3.6/os.py", line 220, in makedirs [2020-04-28T19:13:39.193Z] 1: mkdir(name, mode) [2020-04-28T19:13:39.193Z] 1: FileExistsError: [Errno 17] File exists: 'some_dir/build/x86_debug/ros2/build_docker/functions/ament_cmake_gtest' ``` Signed-off-by: Florian Berchtold <florian.berchtold@gmail.com>
dirk-thomas
reviewed
Apr 29, 2020
Signed-off-by: blackliner <florian.berchtold@gmail.com>
|
Thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran ctest . -j 10, and sometimes it happened that we got failing CI builds because the command in line 116 was executed in parallel.