Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add actual test time to xUnit result files #270

Merged
merged 3 commits into from
Aug 12, 2020

Conversation

ruffsl
Copy link
Contributor

@ruffsl ruffsl commented Aug 11, 2020

Fixes #269
cc @dirk-thomas

Fixes ament#269

Signed-off-by: ruffsl <roxfoxpox@gmail.com>
@dirk-thomas dirk-thomas added the enhancement New feature or request label Aug 12, 2020
Signed-off-by: ruffsl <roxfoxpox@gmail.com>
Signed-off-by: ruffsl <roxfoxpox@gmail.com>
@dirk-thomas
Copy link
Contributor

Linux CI build testing ament_cmake_test only to double check the linters: Build Status

@dirk-thomas
Copy link
Contributor

Thanks for the improvement.

@dirk-thomas dirk-thomas merged commit 191f1d4 into ament:master Aug 12, 2020
@ruffsl ruffsl deleted the test-time branch August 12, 2020 21:50
@dirk-thomas
Copy link
Contributor

This caused the Jenkins plugin to bail on the time attribute values. See #271 for the proposed fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add actual test time to xUnit result files
2 participants