consider LOCATION property if IMPORTED_LOCATION is not set

[dirk-thomas]

No description provided.

[wjwwood]

lgtm.

Is this somehow related to ros2/rmw_connext#126? I see that you're looping over the different configurations, but it's not clear to me that iterating over _imported_configurations is equivalent to non imported library without a mapping. I mention the configuration mapping here ros2/rmw_connext#126 (comment).

[dirk-thomas]

I don't think it is related. I created this only to address parts of ros2/rmw_fastrtps#75.

[mikaelarguedas]

This broke the windows builds, the linker tries to link .dll rather than .lib and thus fails (cf http://ci.ros2.org/job/ci_windows/2053/consoleFull search for "fatal error LNK1107")

Job pass once this reverted:

[esteve]

So, should the approach in PR be improved or should the one in ros2/rmw_fastrtps#75 be merged instead? I have to admit I only tested the latter on OSX and Linux, so I don't know if it'll work on Windows, but it follows the same pattern as rmw_opensplice and rmw_connext, so there's a chance it'll build fine.

[dirk-thomas]

@mikaelarguedas Sorry for the problem. And thanks for fixing it.

@esteve We will revisit after the beta. The open ticket on rmw fastrtps should be enough to keep track of this.

[esteve]

@dirk-thomas no problem. I've addressed your feedback in ros2/rmw_fastrtps#75, so I wonder what's blocking it from being merged, the changes don't seem to me to be too invasive.

[dirk-thomas]

We are already in code freeze for the beta.

[esteve]

@dirk-thomas sorry if I sounded pushy, thanks for the update :-) Good luck 👍 👍 !