fix finding resources in overlayed workspaces #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If I understand the code correctly, Windows doesn't replicate the new behavior. Do we support overlayed workspaces in Windows? |
dirk-thomas
force-pushed
the
resources_in_overlayed_ws
branch
from
bdf44e2
to
73b7eb5
Compare
|
Great catch. I added the missing check in the Windows block. |
|
+1 |
dirk-thomas
added a commit
that referenced
this pull request
Nov 3, 2015
fix finding resources in overlayed workspaces
dirk-thomas
added a commit
that referenced
this pull request
Nov 3, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before when finding any resource in a workspace aborted searching in underlayed workspaces. Instead we always have to consider all workspaces but only use the highest level entry with the same name.