Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test coverage ament_index_cpp #40

Merged
merged 3 commits into from
Jan 22, 2020
Merged

Conversation

Blast545
Copy link
Contributor

Tests added to remaining functions in the package

Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
Copy link
Contributor

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Blast545 I left some minor comments, otherwise LGTM!

ament_index_cpp/test/utest.cpp Outdated Show resolved Hide resolved
ament_index_cpp/test/utest.cpp Outdated Show resolved Hide resolved
ament_index_cpp/test/utest.cpp Outdated Show resolved Hide resolved
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545 Blast545 self-assigned this Jan 21, 2020
@Blast545 Blast545 added the enhancement New feature or request label Jan 21, 2020
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Copy link
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Blast545 Blast545 merged commit 22cff33 into ament:master Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants