Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code refactors to the ament_index_python test #43

Merged
merged 6 commits into from
Jan 27, 2020
Merged

Code refactors to the ament_index_python test #43

merged 6 commits into from
Jan 27, 2020

Conversation

Blast545
Copy link
Contributor

The refactors are submitted in different commits for easier tracking, these are:

  • Replace try/except to catch exceptions, using the with context clause now
  • pathlib preferred over os.path functions
  • Replace format with f-strings
  • Removing comments

@Blast545
Replace try/except with context exception tests
505bb24 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Replace some os path utilities with pathlib ones
54f13c0 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Replaces format string with f-string
a27430d 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Removes extra comments
50f7a7b 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@ivanpauno ivanpauno changed the title Code refactors to the ament_index_python package Code refactors to the ament_index_python test Jan 24, 2020
@ivanpauno ivanpauno added the in review Waiting for review (Kanban column) label Jan 24, 2020
@Blast545
Revert "Removes extra comments"
e9bf2cb 
This reverts commit 50f7a7b.

Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
ivanpauno
ivanpauno approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI!

@Blast545
Test baseclass KeyError
ac2a108 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Copy link
Contributor Author

Blast545 commented Jan 24, 2020 •
edited
Loading

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Blast545 Blast545 merged commit ffa268a into master Jan 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the blast545/py_refactor branch January 27, 2020 15:18
@Blast545 Blast545 removed the in review Waiting for review (Kanban column) label Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas approved these changes

@ivanpauno ivanpauno ivanpauno approved these changes

Assignees

@Blast545 Blast545

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Blast545 @dirk-thomas @ivanpauno