add support for licenses #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will keep iterating on this while processing the current repos:
|
dirk-thomas
force-pushed
the
ament_copyright_reloaded
branch
from
8c2a9d7
to
706d60f
Compare
| See the License for the specific language governing permissions and | ||
| limitations under the License.""", | ||
|
|
||
| """\ |
There was a problem hiding this comment.
Wouldn't it be better to move the text of the license to a separate file and read it?
|
@esteve I moved the apache2 snippets to separate files and modified the behavior to not replace the copyright template in the LICENSE files. All repos have been updated accordingly. |
| @@ -2,11 +2,18 @@ ament_copyright | |||
| =============== | |||
|
|
|||
| Checks C / C++ / CMake / Python source files for the existance of a copyright | |||
| notice. | |||
| and licence notice. | |||
|
+1 |
|
The changes to the other repositories look good to me, still reviewing the code in this pr. |
dirk-thomas
force-pushed
the
ament_copyright_reloaded
branch
from
3bf1508
to
7f05f31
Compare
|
Looks good to me. +1 |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combined copyright and license checking.
Currently implemented entry points:
Connects to #10