Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the 3-Clause BSD license #205

Merged
merged 6 commits into from
Jan 30, 2020
Merged

Add support for the 3-Clause BSD license #205

merged 6 commits into from
Jan 30, 2020

Conversation

Blast545
Copy link
Contributor

Add templates, and test cases to support 3-Clause BSD license as stated in:
https://opensource.org/licenses/BSD-3-Clause

This will allow to use the 3-Clause BSD license without the confusion caused on the 'BSD2' legacy license used in Ros packages (Although it's stated as license 2.0, it is similar to the BSD-3-Clause).

This should help solving geometry2/pull/222 and it will close #109

@Blast545
Add support for the 3-Clause BSD license
ce935ea 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Add missing entry setup.py file for the added license
2b8ba96 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Add test cases for .cpp and .py files
bce1e71 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545 Blast545 mentioned this pull request Jan 29, 2020
Closed
@Blast545 Blast545 added the enhancement New feature or request label Jan 29, 2020
@Blast545 Blast545 self-assigned this Jan 29, 2020
@Blast545
Add a newline to increase readability
bfb294d 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
dirk-thomas
dirk-thomas reviewed Jan 29, 2020
View reviewed changes
Copy link
Contributor

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither of the new test cases seems to be actually used / tested?

ament_copyright/test/cases/3clause_bsd/case2.cpp Outdated Show resolved Hide resolved
@Blast545
Copy link
Contributor Author

You are right, I forgot add them to the test_copyright.py file, I'll add them

@Blast545
Fix missing addition needed to use 3-clause bsd tests
c1990c6 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Remove line not usable
fd8fc53 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Copy link
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Blast545 Blast545 merged commit 70be896 into master Jan 30, 2020
@delete-merged-branch delete-merged-branch bot deleted the blast545/ament_copyright_bsd3 branch January 30, 2020 17:46
tfoote added a commit that referenced this pull request Jan 31, 2020
@tfoote
Remove invalid license template.
15477df 
Flagged in #109 this  template is not a valid template for a license.
The correct license was added in #205

Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
@tfoote tfoote mentioned this pull request Jan 31, 2020
Open
@tfoote tfoote mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfoote tfoote tfoote approved these changes

@dirk-thomas dirk-thomas dirk-thomas approved these changes

Assignees

@Blast545 Blast545

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BSD2_Header templates doesn't match opensource.org reference
3 participants
@Blast545 @tfoote @dirk-thomas