Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ament_cppcheck is failing with a KeyError on rmw_connext_cpp #24

Closed
tfoote opened this issue Jun 25, 2015 · 5 comments
Closed

ament_cppcheck is failing with a KeyError on rmw_connext_cpp #24

tfoote opened this issue Jun 25, 2015 · 5 comments
Assignees

Comments

@tfoote
Copy link
Member

tfoote commented Jun 25, 2015

The file exists, The report variable appears to not have been initialized properly.

line with error in traceback

Traceback (most recent call last):
  File "/home/rosbuild/ci_scripts/workspace/install/bin/ament_cppcheck", line 9, in <module>
    load_entry_point('ament-cppcheck==0.0.0', 'console_scripts', 'ament_cppcheck')()
  File "/home/rosbuild/ci_scripts/workspace/install/lib/python3.4/site-packages/ament_cppcheck-0.0.0-py3.4.egg/ament_cppcheck/main.py", line 115, in main
KeyError: 'src/functions.cpp'

@wjwwood
Copy link
Contributor

wjwwood commented Jun 25, 2015

@dirk-thomas and I were just talking about that. I pointed out to him that it's failing on the farm:

http://ci.ros2.org/job/ros2_batch_ci_linux/6/testReport/rmw_connext_cpp/cppcheck/missing_result/

He said he's going to look into it.

@dirk-thomas dirk-thomas self-assigned this Jun 25, 2015
@dirk-thomas
Copy link
Contributor

As a follow up the linter indicates a memory leak in rmw_connext_cpp:http://ci.ros2.org/job/ros2_batch_ci_linux/7/testReport/rmw_connext_cpp/cppcheck/error__memleak__src_functions_cpp_954_/

@wjwwood Are you already in the process of refactoring the allocation / deallocation in rmw?

@wjwwood
Copy link
Contributor

wjwwood commented Jun 25, 2015

Yes. I'm almost done with connext dynamic. I'll open some pull request when I finish it. Then I'll do connext and open splice too. I'll make sure to follow up on that warning explicitly.

@tfoote
Copy link
Member Author

tfoote commented Jun 25, 2015

There's a debugging print in that commit: 58515dc#diff-e801a73ffe02dfdbed0c68181d791d5eR121

@dirk-thomas
Copy link
Contributor

Thanks for catching that: removed in c4098a8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants