Remove output on stderr for case that is not an error #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
|
Regression from #247. |
dirk-thomas
approved these changes
May 18, 2020
Blast545
changed the title
hidmic
approved these changes
May 18, 2020
|
The title is pretty misleading since the essential change is the removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves copyright test fails caused by #247. For the case of not a main repo file, the
ament_copyrightlinter returned "no error" but printed info onstderrand didn't generate a result xml file.Failing nightly CI before the fix:
CI with packages that were reporting copyright errors before this fix:
Signed-off-by: Jorge Perez jjperez@ekumenlabs.com