Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional file header style #304

Merged
merged 2 commits into from
Mar 16, 2021
Merged

Add optional file header style #304

merged 2 commits into from
Mar 16, 2021

Conversation

threeal
Copy link
Contributor

@threeal threeal commented Mar 3, 2021

Closes #303

@threeal threeal force-pushed the 303-alternative-license-header-option branch from da2a972 to 51b521a Compare March 3, 2021 04:46
@tfoote
Copy link
Member

tfoote commented Mar 3, 2021

Thanks for helping extend this. It will make things easier for many people.

@audrow audrow self-assigned this Mar 12, 2021
audrow
audrow approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the PR, @threeal. We can merge this in with green CI.

@audrow
Copy link
Contributor

audrow commented Mar 12, 2021 •
edited
Loading

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@audrow
Copy link
Contributor

audrow commented Mar 15, 2021

Once the linter warning is taken care of, this should be good to go. @threeal, let me know if you need any help with this.

@threeal
Copy link
Contributor Author

threeal commented Mar 16, 2021

@audrow sorry, i just know if you waiting me to fix this, will do it ASAP.

@threeal threeal force-pushed the 303-alternative-license-header-option branch from 3ee4870 to def21b2 Compare March 16, 2021 04:30
@audrow
Copy link
Contributor

audrow commented Mar 16, 2021 •
edited
Loading

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@audrow
Copy link
Contributor

audrow commented Mar 16, 2021

@ros-pull-request-builder retest this please

@threeal @audrow
Add optional file header style
f5f6438 
Signed-off-by: Alfi Maulana <alfi.maulana.f@gmail.com>
@threeal @audrow
Fix test on ament_copyright
e132596 
Signed-off-by: Alfi Maulana <alfi.maulana.f@gmail.com>
@audrow audrow force-pushed the 303-alternative-license-header-option branch from def21b2 to e132596 Compare March 16, 2021 15:36
@audrow
Copy link
Contributor

audrow commented Mar 16, 2021

CI after a rebase:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@audrow
Copy link
Contributor

audrow commented Mar 16, 2021

The CI errors are a known bug: ros2/demos#490.

@audrow audrow merged commit caf7cab into ament:master Mar 16, 2021
@audrow
Copy link
Contributor

audrow commented Mar 16, 2021

Thanks for the PR, @threeal!

@christophebedard christophebedard mentioned this pull request Mar 16, 2021
Merged
@threeal threeal deleted the 303-alternative-license-header-option branch July 28, 2021 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@audrow audrow audrow approved these changes

Assignees

@audrow audrow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alternative License Header Option for ament_copyright
3 participants
@threeal @tfoote @audrow