Use non-blind except for open() #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
audrow
approved these changes
Mar 16, 2021
|
Just to make sure:
|
|
Thanks for the PR, @christophebedard! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #304
CI uses
flake8-blind-except==0.1.1: https://ci.ros2.org/job/ci_linux/13949/consoleFull#console-section-9. However, using the newest version (0.2.0) leads to a flake8 error:I thought I'd propose this change for others like me who build from source and often use the latest versions.
Relates to #292 a bit