Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cpplint #54

Merged
merged 2 commits into from
Jun 10, 2016
Merged

update cpplint #54

merged 2 commits into from
Jun 10, 2016

Conversation

dirk-thomas
Copy link
Contributor

Since upstream has modified their repository root algorithm the second commit is necessary to find the vcs root with the longest path (see google/styleguide#145).

http://ci.ros2.org/job/ci_osx/1114/

@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Jun 10, 2016
@dirk-thomas dirk-thomas self-assigned this Jun 10, 2016
@wjwwood
Copy link
Contributor

wjwwood commented Jun 10, 2016

+1

@dirk-thomas dirk-thomas merged commit 9ab7a1d into master Jun 10, 2016
@dirk-thomas dirk-thomas deleted the update_cpplint branch June 10, 2016 19:07
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Jun 10, 2016
@wjwwood
Copy link
Contributor

wjwwood commented Jun 14, 2016

I think this cpplint failure is a regression of this:

http://ci.ros2.org/job/ci_linux/1439/testReport/rcl/cpplint/build_include__5____home_rosbuild_ci_scripts_ws_src_ros2_rcl_rcl_src_rcl_common_c_20_/

Any idea how to address that? I don't think including it from rcl/src/rcl/common.h, as cpplint suggests, is the right thing to do. Should I just disable linting on that line?

@dirk-thomas
Copy link
Contributor Author

Suppressed in ros2/rcl@10c14e0 and ros2/rosidl@461b4d5

@wjwwood
Copy link
Contributor

wjwwood commented Jun 14, 2016

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants