Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use flake8 instead of pep8 and pyflakes #78

Merged
merged 2 commits into from
Jun 21, 2017
Merged

use flake8 instead of pep8 and pyflakes #78

merged 2 commits into from
Jun 21, 2017

Conversation

dirk-thomas
Copy link
Contributor

Connect to ament/ament_index#25.

@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Jun 21, 2017
@dirk-thomas dirk-thomas self-assigned this Jun 21, 2017
wjwwood
wjwwood approved these changes Jun 21, 2017
View reviewed changes
Copy link
Contributor

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why the copyright years were changing (maybe copy-paste?), but otherwise lgtm.

@dirk-thomas
Copy link
Contributor Author

I'm not sure why the copyright years were changing (maybe copy-paste?), but otherwise lgtm.

git thinks these files have been renamed. Instead the old files have been deleted and new files for flake8 created. The copyright year in the new files is the same as from the file they have been copied from (from other packages).

@dirk-thomas dirk-thomas merged commit bdfec56 into master Jun 21, 2017
@dirk-thomas dirk-thomas deleted the use_flake8 branch June 21, 2017 23:09
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dirk-thomas @wjwwood