opt to pass the language through to cppcheck #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CMake function ( ) should exposeLANGUAGE as an explicit optional single value argument (similar as ament_lint/ament_cmake_uncrustify/cmake/ament_uncrustify.cmake Lines 20 to 22 in bdfec56 |
dirk-thomas
reviewed
Jun 22, 2017
| @@ -36,6 +38,9 @@ function(ament_cppcheck) | |||
| set(result_file "${AMENT_TEST_RESULTS_DIR}/${PROJECT_NAME}/${ARG_TESTNAME}.xunit.xml") | |||
| set(cmd "${ament_cppcheck_BIN}" "--xunit-file" "${result_file}") | |||
| list(APPEND cmd ${ARG_UNPARSED_ARGUMENTS}) | |||
| if(ARG_LANGUAGE) | |||
| list(APPEND cmd "--languge" "${ARG_LANGUAGE}") | |||
There was a problem hiding this comment.
--languge: spelling.
Same in the docblock.
There was a problem hiding this comment.
Please don't edit (there is no notification).
dirk-thomas
approved these changes
Jun 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to ros2/ros2#368