build prefix command is naive

[wjwwood]

This function:

https://github.com/ament/ament_tools/blob/master/ament_tools/build_types/cmake.py#L346-L364

Currently sources dependencies of the package being built in an arbitrary order if they have a local_setup.* file.

Instead it should source the local_setup.* files for the recursive build dependencies and they should be sourced in topological order.

[dirk-thomas]

build_dependencies in this context (

ament_tools/ament_tools/build_types/cmake.py

Line 349 in 6ce9ab3

for path in context.build_dependencies:

) are not the direct build dependencies of the package specified in the manifest. This list already contains all recursive dependencies in topological order (determined by

ament_tools/ament_tools/topological_order.py

Line 117 in 6ce9ab3

def topological_order_packages(

).

Therefore I don't think anything needs to be changed here?

[dirk-thomas]

Based on the output of #62 it looks like that the order is correct. The problem is that the environment files include not only the recursive dependencies but also downstream packages - basically all packages of the workspace.

[wjwwood]

@dirk-thomas But they should be skipped because they don't have environment hooks inside the workspace? or is it a problem when you install two workspaces to the same install space?

[dirk-thomas]

Sorry, I meant downstream packages. E.g. ament_cppcheck doesn't have any dependencies but currently uses the environment of all packages in the workspace (which is only the case when rebuilding a workspace again).

[wjwwood]

Oh, it's not just the dependencies, but also anything that comes before in the topological order.

[dirk-thomas]

It includes even packages which come afterwards in the topological order.

[dirk-thomas]

For packages with dependencies on other ament packages the list and order is correct. But for packages without dependencies on other ament packages the list contains all packages from the workspace. The fix is simple: #63.