Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(eslint-config-amex): update 15.x #45

Merged
merged 2 commits into from
May 26, 2022
Merged

chore(eslint-config-amex): update 15.x #45

merged 2 commits into from
May 26, 2022

Conversation

JAdshead
Copy link
Contributor

@JAdshead JAdshead commented May 26, 2022 •
edited
Loading

Description

update eslint and eslint config amex and jest

Motivation and Context

ensure this uses the latest linting standards

How Has This Been Tested?

npm test

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using babel-preset-amex?

@JAdshead JAdshead requested review from a team as code owners May 26, 2022 17:59
Matthew-Mallimo
Matthew-Mallimo reviewed May 26, 2022
View reviewed changes
package.json
"husky": "^4.3.0",
"jest": "^25.5.4",
"jest": "^28.1.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This upgraded without any issues?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test don't run on node 10

@Matthew-Mallimo Matthew-Mallimo requested a review from a team May 26, 2022 18:03
@JAdshead
chore(workflows): use node 16
1727564 
BREAKING CHANGE: drops support for node 10, 12, and 14
@10xLaCroixDrinker 10xLaCroixDrinker requested review from a team May 26, 2022 18:07
@JAdshead JAdshead enabled auto-merge (squash) May 26, 2022 18:49
@JAdshead JAdshead disabled auto-merge May 26, 2022 18:50
@JAdshead JAdshead enabled auto-merge (squash) May 26, 2022 18:50
@JAdshead JAdshead merged commit f2d501c into main May 26, 2022
@JAdshead JAdshead deleted the chore/eslint-update branch May 26, 2022 20:30
oneamexbot added a commit that referenced this pull request May 26, 2022
@oneamexbot
chore(release): 4.0.0 [skip ci]
f9f2493 
# [4.0.0](v3.6.1...v4.0.0) (2022-05-26)

### chore

* **eslint-config-amex:** update 15.x ([#45](#45)) ([f2d501c](f2d501c))

### BREAKING CHANGES

* **eslint-config-amex:** drops support for node 10, 12, and 14
@oneamexbot
Copy link
Contributor

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@10xLaCroixDrinker 10xLaCroixDrinker 10xLaCroixDrinker approved these changes

@Matthew-Mallimo Matthew-Mallimo Matthew-Mallimo approved these changes

Assignees
No one assigned
Labels
one-app-team-review-requested released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JAdshead @oneamexbot @10xLaCroixDrinker @Matthew-Mallimo