fix(makeServerFetchye): mask errors from server side fetching #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a fetch fails in SSR, we now drop the error entirely. This prevents unserializable Errors ending up in the redux store.
This also provides a better behaviour for SSR where failed fetches still render a loading state, allowing the browser to 'try again' fetching the data
Motivation and Context
This removes a 'cannot serialize' error from being emitted on the server when a fetch fails.
How Has This Been Tested?
Using a local instance of one app and some test modules I have proved that SSR now renders a 'loading' state of the application, without logging 'cannot serialize' errors, when a fetch fails in the server.
I have Unit test coverage for all new code.
Types of Changes
Checklist:
What is the Impact to Developers Using Fetchye?
None