Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

feat(selector): rename and expose loaded selectors #43

Merged

Conversation

drewcur
Copy link
Collaborator

@drewcur drewcur commented Aug 15, 2022

Expose the "loaded" selectors for resources and collections under modified names that match the current API.

Motivation and Context

This is done, primarily, to make it possible check for data to be loaded within collections as getCollection will always return an empty array regardless of it being requested or not. Added in additional for resources for parity.

How Has This Been Tested?

Unit testing, then locally packing the repo and integrating into another library.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using Iguazu-Rest?

None, forward change that only adds functionality.

@JAdshead JAdshead requested a review from a team August 15, 2022 20:39
@10xLaCroixDrinker 10xLaCroixDrinker merged commit 3f6cfba into americanexpress:main Aug 18, 2022
oneamexbot added a commit that referenced this pull request Aug 18, 2022
# [1.11.0](v1.10.2...v1.11.0) (2022-08-18)

### Features

* **selector:** rename and expose loaded selectors ([#43](#43)) ([3f6cfba](3f6cfba))
@oneamexbot
Copy link
Contributor

🎉 This PR is included in version 1.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants