Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

fix(cache-cdn): stringify object #1138

Merged
merged 1 commit into from
Sep 28, 2023
Merged

fix(cache-cdn): stringify object #1138

merged 1 commit into from
Sep 28, 2023

Conversation

bishnubista
Copy link
Contributor

Fix initialization of cache object and stringify.
JSON.stringify('{}') to JSON.stringify({})

Description

Motivation and Context

It caused caching issue, as it was trying to key value in string instead of object.

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

@github-actions
Copy link
Contributor

Size Change: 0 B

Total Size: 710 kB

ℹ️ View Unchanged
Filename Size
./build/app/app.js 164 kB
./build/app/app~vendors.js 411 kB
./build/app/runtime.js 7.07 kB
./build/app/service-worker-client.js 7.25 kB
./build/app/vendors.js 121 kB

compressed-size-action

@JAdshead JAdshead merged commit 8715017 into main Sep 28, 2023
10 checks passed
@JAdshead JAdshead deleted the fix/cacheCdn branch September 28, 2023 19:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants