Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

fix(conditionallyAllowCors): nested array of cors origins #14

Merged
merged 2 commits into from
Jan 21, 2020

Conversation

JAdshead
Copy link
Contributor

No description provided.

@JAdshead JAdshead requested a review from a team as a code owner January 21, 2020 18:28
@oneamexbot
Copy link
Contributor

oneamexbot commented Jan 21, 2020

📊 Bundle Size Report

file name size on disk gzip
app.js 112.4KB 31.3KB
runtime.js 15KB 5.3KB
vendors.js 128KB 37.9KB
app~vendors.js 403.8KB 105.7KB
legacy/app.js 119KB 32.9KB
legacy/runtime.js 15KB 5.3KB
legacy/vendors.js 163.1KB 44.9KB
legacy/app~vendors.js 410.2KB 107.4KB

☑️ Preflight Checklist:

All questions must be addressed before this PR can be merged.

  • What is the communication plan for this change?
  • Does any documentation need to be updated or added to account for this change? If so was it done already?
  • What is the motivation for this change?
  • Should these changes also be applied to a maintenance branch or any other long lived branch?
  • How was this change tested?
  • Does this change require cross browser checks? Why or why not?
  • Does this change require a performance test prior to merging? Why or why not?
  • Could this be considered a breaking change? Why or why not?
  • Does the change impact caching?
  • Does the change impact HTTP headers?
  • Does the change have any new infrastructure requirements?
  • Does the change affect other versions of the app?
  • Does the change require additional environment variables?
  • What is the impact to tenants?
  • What is the impact to individual users?
  • What is the change to the size of assets?
  • Should integration tests be added to protect against future regressions on this change?

Generated by 🚫 dangerJS against 5175951

@JAdshead JAdshead merged commit 75ba553 into master Jan 21, 2020
@JAdshead JAdshead deleted the fix/conditionallyAllowCors branch January 21, 2020 21:28
@nellyk nellyk added the fix label Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants