Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

fix(clientModuleMapCache): set base url for module bundle type #215

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

JAdshead
Copy link
Contributor

Description

Ensure base url is correct for each module bundle.

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

@JAdshead JAdshead requested review from a team as code owners June 26, 2020 22:11
@oneamexbot
Copy link
Contributor

oneamexbot commented Jun 26, 2020

📊 Bundle Size Report

file name size on disk gzip
app.js 275.3KB 82.2KB
runtime.js 15KB 5.4KB
vendors.js 117.2KB 36.4KB
app~vendors.js 432.4KB 112.2KB
service-worker-client.js 17KB 5.2KB
legacy/app.js 290.6KB 85.3KB
legacy/runtime.js 15KB 5.4KB
legacy/vendors.js 163.4KB 44.7KB
legacy/app~vendors.js 441.3KB 114.5KB
legacy/service-worker-client.js 17.5KB 5.4KB

Generated by 🚫 dangerJS against 6659436

@JAdshead JAdshead merged commit 95ca35f into master Jun 30, 2020
@JAdshead JAdshead deleted the fix/module-map-base-url branch June 30, 2020 16:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants