Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

fix(pollModuleMap): ensure single pollModuleMap #284

Merged
merged 4 commits into from
Aug 25, 2020
Merged

Conversation

JAdshead
Copy link
Contributor

Description

Ensure that there is only one timer for pollModuleMap and include additional metrics.

Motivation and Context

Its possible for multiple timers to be set for pollModuleMap.
as pollModuleMap sets timeout to call itself this can lead to a slow increase in the total number of timers calling pollModuleMap. There should only be one.

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

@JAdshead JAdshead requested review from a team as code owners August 24, 2020 19:48
@github-actions github-actions bot added the fix label Aug 24, 2020
@oneamexbot
Copy link
Contributor

oneamexbot commented Aug 24, 2020

Warnings
⚠️

Changes were made to package.json, but not to package-lock.json - Perhaps you need to run npm install?

📊 Bundle Size Report

file name size on disk gzip
app.js 275.4KB 82.2KB
runtime.js 15KB 5.4KB
vendors.js 117.2KB 36.4KB
app~vendors.js 432.5KB 112.2KB
service-worker-client.js 17KB 5.2KB
legacy/app.js 290.7KB 85.4KB
legacy/runtime.js 15KB 5.4KB
legacy/vendors.js 163.4KB 44.7KB
legacy/app~vendors.js 441.3KB 114.5KB
legacy/service-worker-client.js 17.5KB 5.4KB

Generated by 🚫 dangerJS against 6ce1603

infoxicator
infoxicator previously approved these changes Aug 25, 2020
package.json Show resolved Hide resolved
@JAdshead JAdshead merged commit 5503a03 into master Aug 25, 2020
@JAdshead JAdshead deleted the fix/memory-leak branch August 25, 2020 19:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants