Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

feat(runtime): support node 16 #624

Merged
merged 2 commits into from
Nov 29, 2021

Conversation

10xLaCroixDrinker
Copy link
Member

Description

This includes the changes in #611, adding the support without changing the image and integration tests.

Motivation and Context

Prep for v6

How Has This Been Tested?

npm test

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2021

📊 Bundle Size Report

file name size on disk gzip
app.js 313.4KB 93.1KB
runtime.js 15.6KB 5.5KB
vendors.js 129.1KB 40KB
app~vendors.js 426.7KB 110.4KB
service-worker-client.js 17.1KB 5.3KB
legacy/app.js 334.7KB 97.9KB
legacy/runtime.js 15.6KB 5.5KB
legacy/vendors.js 189.4KB 51.7KB
legacy/app~vendors.js 450.4KB 116.2KB
legacy/service-worker-client.js 17.6KB 5.5KB

Generated by 🚫 dangerJS against 506e0d3

@10xLaCroixDrinker 10xLaCroixDrinker requested a review from a team November 29, 2021 17:28
@10xLaCroixDrinker 10xLaCroixDrinker merged commit f8752d6 into main Nov 29, 2021
@10xLaCroixDrinker 10xLaCroixDrinker deleted the feature/node-16-sans-integration branch November 29, 2021 18:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants