Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

fix(one-app-ducks): delete lang pack request errors #722

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

JAdshead
Copy link
Contributor

Description

update one-app-ducks

Motivation and Context

includes fix for in one-app-ducks which correctly removes errors on successful retry of lang pack request

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

@code-forger code-forger requested a review from a team April 28, 2022 19:02
@github-actions
Copy link
Contributor

📊 Bundle Size Report

file name size on disk gzip
app.js 314.7KB 93.4KB
runtime.js 15.6KB 5.5KB
vendors.js 148.2KB 47.6KB
app~vendors.js 431.2KB 112.6KB
service-worker-client.js 17.1KB 5.3KB
legacy/app.js 335.6KB 98.3KB
legacy/runtime.js 15.6KB 5.5KB
legacy/vendors.js 211KB 59.7KB
legacy/app~vendors.js 453KB 118.3KB
legacy/service-worker-client.js 17.6KB 5.5KB

Generated by 🚫 dangerJS against 3882447

@10xLaCroixDrinker 10xLaCroixDrinker enabled auto-merge (squash) April 28, 2022 19:16
@10xLaCroixDrinker 10xLaCroixDrinker merged commit b08ea4e into main Apr 28, 2022
@10xLaCroixDrinker 10xLaCroixDrinker deleted the fix/one-app-ducks branch April 28, 2022 19:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants