Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

fix(fetch-enhancers): use tree-shakable es build #748

Merged
merged 1 commit into from
May 25, 2022

Conversation

JAdshead
Copy link
Contributor

Description

Updated @americanexpress/fetch-enhancers to 1.1.2 which now creates a esm build that can be more efficiently tree shaken.

Motivation and Context

reduce app.js bundle size

How Has This Been Tested?

bundling and analyzing build locally

before:

Screen Shot 2022-05-25 at 2 39 42 PM

after:

Screen Shot 2022-05-25 at 2 39 49 PM

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

@JAdshead JAdshead requested review from a team as code owners May 25, 2022 21:40
@github-actions github-actions bot added the fix label May 25, 2022
@JAdshead JAdshead enabled auto-merge (squash) May 25, 2022 21:40
@github-actions
Copy link
Contributor

📊 Bundle Size Report

file name size on disk gzip
app.js 137.1KB 37.5KB
runtime.js 15.6KB 5.5KB
vendors.js 148.2KB 47.6KB
app~vendors.js 431.2KB 112.6KB
service-worker-client.js 17.1KB 5.3KB
legacy/app.js 150KB 41KB
legacy/runtime.js 15.6KB 5.5KB
legacy/vendors.js 211.2KB 59.8KB
legacy/app~vendors.js 452.7KB 118.2KB
legacy/service-worker-client.js 17.6KB 5.5KB

Generated by 🚫 dangerJS against 70496a5

@JAdshead JAdshead merged commit 26b26ab into main May 25, 2022
@JAdshead JAdshead deleted the fix/fetch-enhancer-size branch May 25, 2022 23:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants