Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

feat(loader): upgrade purgecss version #9

Merged
merged 6 commits into from
Apr 28, 2020

Conversation

infoxicator
Copy link
Contributor

@infoxicator infoxicator commented Apr 15, 2020

This is a non-breaking change for consumers

  1. fontFace
  2. keyFrames
  3. variables
  4. whitelist
  5. whitelistPatters
  6. whitelistPatternsChildren

TESTING:

Tested doing npm pack and installing this version in one-app-bundler, then npm pack again and installed the updated bundler in one of the docs repositories, confirming the changes indeed allow :global{} classes when purgecss loader is enabled in the bundler configuration and it removes unused classes even if wrapped in :global{}

@infoxicator infoxicator requested a review from a team as a code owner April 15, 2020 12:59
@CLAassistant
Copy link

CLAassistant commented Apr 15, 2020

CLA assistant check
All committers have signed the CLA.

@infoxicator infoxicator force-pushed the feature/purgcss-version-upgrade branch from f90c9ab to 6df92c4 Compare April 15, 2020 13:12
__fixtures__/root.scss Outdated Show resolved Hide resolved
__tests__/loader.spec.js Outdated Show resolved Hide resolved
mtomcal
mtomcal previously approved these changes Apr 21, 2020
JAdshead
JAdshead previously approved these changes Apr 21, 2020
nellyk
nellyk previously approved these changes Apr 22, 2020
@nellyk
Copy link
Contributor

nellyk commented Apr 22, 2020

Could we please hold off on merging this until we've added semantic release #10

@infoxicator infoxicator dismissed stale reviews from nellyk, JAdshead, and mtomcal via 8fa87c5 April 27, 2020 11:18
@infoxicator infoxicator merged commit 44886a3 into master Apr 28, 2020
@infoxicator infoxicator deleted the feature/purgcss-version-upgrade branch April 28, 2020 10:02
oneamexbot added a commit that referenced this pull request Apr 28, 2020
# 1.0.0 (2020-04-28)

### chore

* **travis:** remove node 6 from travis config ([c6360fc](c6360fc))

### Features

* **loader:** intial dev ([5be240c](5be240c))
* **loader:** upgrade purgecss version ([#9](#9)) ([44886a3](44886a3))

### BREAKING CHANGES

* **travis:** drop support for node 6
oneamexbot added a commit that referenced this pull request Apr 28, 2020
# [2.0.0](v1.0.0...v2.0.0) (2020-04-28)

### chore

* **travis:** remove node 6 from travis config ([c6360fc](c6360fc))

### Features

* **loader:** upgrade purgecss version ([#9](#9)) ([44886a3](44886a3))

### Reverts

* Revert "chore(release): 1.0.0 " (#12) ([f79e503](f79e503)), closes [#12](#12)

### BREAKING CHANGES

* **travis:** drop support for node 6
@oneamexbot
Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add ability to whitelist selectors
8 participants