Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release-please): use npmrc and set registry #52

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

JAdshead
Copy link
Contributor

@JAdshead JAdshead commented Feb 6, 2024

Description

include .npmrc
use --access public flag as package is scoped.

we may want this to go in as a fix to trigger a release as the previous release failed with invalid npm token.

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • This change impacts caching for client browsers.
  • This change adds additional environment variable requirements for vitruvius users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using vitruvius?

@JAdshead JAdshead force-pushed the chore/release-process-use-npmrc branch from 27de9fc to 87676c4 Compare February 6, 2024 22:29
@JAdshead JAdshead merged commit 2d881d3 into main Feb 7, 2024
3 checks passed
@JAdshead JAdshead deleted the chore/release-process-use-npmrc branch February 7, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants