Skip to content
This repository has been archived by the owner on Apr 18, 2022. It is now read-only.

[MAINTENANCE] Update to winit 0.20.0 #1786

Closed
azriel91 opened this issue Jul 6, 2019 · 10 comments
Closed

[MAINTENANCE] Update to winit 0.20.0 #1786

azriel91 opened this issue Jul 6, 2019 · 10 comments
Labels
diff: normal Achievable by an reasonable experienced developer. If new to Amethyst, may need some guidance. stale Issue had no recent activity team: engine type: maintenance A task that has no noticeable user-facing effect. Code cleanup, small refactors, etc.
Milestone
0.16.0 - Legion

Comments

@azriel91
Copy link
Member

azriel91 commented Jul 6, 2019

Description

Since gfx-hal is updating -- gfx-rs/gfx#2874 -- we should do this as well.

Reason

Keep up to date with the ecosystem.
@azriel91 azriel91 added type: maintenance A task that has no noticeable user-facing effect. Code cleanup, small refactors, etc. status: needs triage labels Jul 6, 2019
@distransient distransient added status: ready team: engine diff: normal Achievable by an reasonable experienced developer. If new to Amethyst, may need some guidance. and removed status: needs triage labels Jul 19, 2019
@Jaspi10 Jaspi10 mentioned this issue Aug 17, 2019
Closed
6 tasks
@stale
Copy link

stale bot commented Sep 17, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Feel free to comment if this ticket is still relevant.

@stale stale bot added the stale Issue had no recent activity label Sep 17, 2019
@OvermindDL1
Copy link

Not stale, gfx update in gfx-rs/gfx#2888 a few days ago.

@stale stale bot removed the stale Issue had no recent activity label Sep 17, 2019
@distransient
Copy link
Member

Will be fixed by #1877

@vultix
Copy link
Contributor

vultix commented Oct 23, 2019

@azriel91 @OvermindDL1 What's preventing this from being merged? Please correct me if I'm wrong, but as far as I can tell this is the only thing blocking OpenGL WASM support in #1877

@OvermindDL1
Copy link

For note, 0.20.0-alpha4 came out in the last few days, fixed a few platform issues.

@distransient
Copy link
Member

Will be fixed sooner in #2040

@chemicstry
Copy link
Member

chemicstry commented Mar 25, 2020 •
edited

Can we close this since it landed into wasm branch or do we keep it open till it lands on master?

@azriel91
Copy link
Member Author

Normally would keep it open until it lands on master, for the small chance another amethyst version may be published before the wasm one.

@AlveLarsson AlveLarsson added this to the Amethyst 0.16 milestone Jun 20, 2020
@stale
Copy link

stale bot commented Dec 18, 2020

This issue has been automatically marked as stale because it has not had recent activity. Maybe it's time to revisit this?

@stale stale bot added the stale Issue had no recent activity label Dec 18, 2020
@ezpuzz
Copy link
Contributor

ezpuzz commented Dec 23, 2020

fixed by #2554

@ezpuzz ezpuzz closed this as completed Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
diff: normal Achievable by an reasonable experienced developer. If new to Amethyst, may need some guidance. stale Issue had no recent activity team: engine type: maintenance A task that has no noticeable user-facing effect. Code cleanup, small refactors, etc.
Projects
None yet
Milestone
0.16.0 - Legion
Development

Successfully merging a pull request may close this issue.

Upgrade winit to 0.20.0-alpha3 Jaspi10/amethyst
7 participants
@chemicstry @OvermindDL1 @ezpuzz @distransient @azriel91 @vultix @AlveLarsson