Skip to content
This repository has been archived by the owner on Apr 18, 2022. It is now read-only.

[BUG] amethyst_net fires NetworkSimulationEvent::Connect twice on a new connection to LaminarSocket #2024

Closed
mvlabat opened this issue Oct 29, 2019 · 5 comments
Labels
diff: easy Achievable by a single junior developer with a bit of guidance. good first issue This is a good issue to start with if you are new and want to contribute to Amethyst. open-when-archived This was open when we decided to archive the repo, so we closed it as per best practices. pri: important Something other teams are relying on, or a low-level, critical piece of functionality. team: network type: bug Something is not working as it should.

Comments

@mvlabat
Copy link
Member

mvlabat commented Oct 29, 2019

Tasks

  • Find why two Connect events are fired
  • Make it not send two events for the same connection

Description

I'm not sure whether this is Laminar or amethyst_net bug. On connecting to Laminar socket amethyst_net fires two NetworkSimulationEvent::Connect events.

Reproduction Steps

  1. Change both net_server and net_client amethyst examples to work on LaminarNetworkBundle
  2. Run

What You Expected to Happen

Only one event is expected.

Screenshots and Logs

[INFO][net_server] New client connection: 127.0.0.1:3455
[INFO][net_server] New client connection: 127.0.0.1:3455

Your Environment

  1. Operating System: Windows 10
  2. Operating System Version: 1903
  3. Version of Amethyst: 457cc03
@stale
Copy link

stale bot commented Apr 26, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Feel free to comment if this ticket is still relevant.

@stale stale bot added the stale Issue had no recent activity label Apr 26, 2020
@mvlabat mvlabat removed the stale Issue had no recent activity label Apr 28, 2020
@mvlabat
Copy link
Member Author

mvlabat commented Apr 28, 2020

The issue is still actual
cc @jstnlef @TimonPost

@stale
Copy link

stale bot commented Oct 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. Maybe it's time to revisit this?

@stale stale bot added the stale Issue had no recent activity label Oct 25, 2020
@mvlabat
Copy link
Member Author

mvlabat commented Oct 26, 2020

Since there were no significant changes in amethyst_net, I guess this is still actual

@stale stale bot removed the stale Issue had no recent activity label Oct 26, 2020
@AnneKitsune AnneKitsune added diff: easy Achievable by a single junior developer with a bit of guidance. good first issue This is a good issue to start with if you are new and want to contribute to Amethyst. pri: important Something other teams are relying on, or a low-level, critical piece of functionality. labels May 18, 2021
@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. Maybe it's time to revisit this?

@stale stale bot added the stale Issue had no recent activity label Apr 16, 2022
@CleanCut CleanCut added the open-when-archived This was open when we decided to archive the repo, so we closed it as per best practices. label Apr 18, 2022
@stale stale bot removed the stale Issue had no recent activity label Apr 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
diff: easy Achievable by a single junior developer with a bit of guidance. good first issue This is a good issue to start with if you are new and want to contribute to Amethyst. open-when-archived This was open when we decided to archive the repo, so we closed it as per best practices. pri: important Something other teams are relying on, or a low-level, critical piece of functionality. team: network type: bug Something is not working as it should.
Projects
None yet
Development

No branches or pull requests

5 participants