Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASM demos on Mac OS X #33

Closed
erlend-sh opened this issue Nov 16, 2019 · 11 comments
Closed

WASM demos on Mac OS X #33

erlend-sh opened this issue Nov 16, 2019 · 11 comments
Assignees
Labels
awaiting confirmation Believed fix, waiting for testing bug Something isn't working

Comments

@erlend-sh
Copy link
Member

I'm getting this when I'm trying to run the demo:

Screenshot 2019-11-16 at 14 49 09

@Zireael07
Copy link

What OS and browser? On Ubuntu 18.04 LTS, Chrome 78.0.3904.97, it works.

@erlend-sh
Copy link
Member Author

MacBook Pro 2019, Firefox. Can’t get the exact version right now.

@thebracket
Copy link
Collaborator

Does the example run if I you use an HTTPS link? I added SSL to the host a while back, and have slacked on adding it to all of the links in the book (and whenever I point people at the tutorial).

https://bfnightly.bracketproductions.com/rustbook/wasm/chapter-61-townportal/

@erlend-sh
Copy link
Member Author

Tried both http and https in latest Firefox, Chrome and Safari on MacBook Pro, Catalina v10.15.1

2,3 GHz Dual-Core Intel Core i5
Intel Iris Plus Graphics 640 1536 MB

All I get is this black screen. It's probably not related to the "connection not secure" warning then so feel free to change the title. I checked on a different, older MacBook and couldn't get it to work there either. Has anyone with a macOS machine gotten it working?

@thebracket
Copy link
Collaborator

I'll see if I can borrow my wife's Macbook this evening to give it a look. Hopefully, I didn't pick a GL mode that isn't happy on OS X!

@thebracket thebracket changed the title WASM demo doesn't run - "Connection not secure" WASM demos on Mac OS X Nov 18, 2019
@thebracket thebracket self-assigned this Nov 18, 2019
@thebracket
Copy link
Collaborator

I managed to get to use a Mac last night, and can confirm that this is an RLTK-level issue: the canvas opens, the WASM executes and logs keystrokes, but nothing gets rendered - just a black box.

I'll open an RLTK issue and link it to this one, and see about getting a library-level fix in ASAP.

@thebracket
Copy link
Collaborator

I believe the issue is fixed in RLTK, pulling and rebuilding the tutorial now.

@thebracket
Copy link
Collaborator

I'm happy to report that the demos are running on my virtual Mac:
image

@thebracket
Copy link
Collaborator

The RLTK changes ended up being very substantial; there's basically a whole new WebGL pipeline now. It's single-pass (or one pass per console layer), the post-process is integrated into the main loop, and it works by sampling dynamic textures rather than a giant vertex buffer - so it's really rather fast.

If anyone could confirm that they are working on a real Mac, I'd appreciate it!

@thebracket thebracket added the awaiting confirmation Believed fix, waiting for testing label Nov 20, 2019
@erlend-sh
Copy link
Member Author

Just confirmed it’s working, thanks so much for the quick turnaround! 👏

Latest Firefox and Chrome both work. Safari does not, which I assume is because their WASM support remains incomplete.

@thebracket
Copy link
Collaborator

I'll go ahead and close this out, then. Thanks! (I'm told that Safari support is a pipe-dream, due to lack of WebGL 2 support - so I won't stress that one.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting confirmation Believed fix, waiting for testing bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants