Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MODULES] Configure the config object that is passed #3

Closed
AdrianGjerstad opened this issue Jan 2, 2021 · 0 comments
Closed

[MODULES] Configure the config object that is passed #3

AdrianGjerstad opened this issue Jan 2, 2021 · 0 comments
Labels
enhancement New feature or request modules Relating to server modules

Comments

@AdrianGjerstad
Copy link
Member

Some methods within a module, directives, blocks, or events, require access to other module's configuration variables. The way Amethyst currently behaves is that it whitelists a couple of core events and directives, blocking any other modules from accessing everything. For blocks, this isn't an issue, since blocks have to get access to the entire config object if they are supposed to conditionally perform the contents inside, which may be from other modules.

The default should be the module's own configuration object, but it should be an option that the module developer can set. Maybe set each directive entry inside directives to be either a plain function (configuration object is the local module's), or an object with options, one of which being the function to execute, say callback.

@AdrianGjerstad AdrianGjerstad added enhancement New feature or request modules Relating to server modules labels Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request modules Relating to server modules
Projects
None yet
Development

No branches or pull requests

1 participant