Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search #3

Closed
amezin opened this issue Oct 8, 2020 · 1 comment
Closed

Search #3

amezin opened this issue Oct 8, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@amezin
Copy link
Member

amezin commented Oct 8, 2020

Currently, VTE search functionality isn't exposed at all.

I also don't like Gnome Terminal's search UI - I'd prefer a search bar instead of a dialog window.
@amezin amezin added the enhancement New feature or request label Oct 8, 2020
@amezin amezin mentioned this issue Jul 29, 2021
Closed
@amezin amezin added the good first issue Good for newcomers label Jul 29, 2021
@amezin
Copy link
Member Author

amezin commented Jul 29, 2021

VTE already implements all necessary functions, so this should be easy to implement for anybody familiar with Gtk and gjs (or at least one of these things).

The only tricky part is that you shouldn't use GtkSearchBar - its layout isn't great (the textbox can't be extended to its full width).

@amezin amezin removed the good first issue Good for newcomers label Sep 28, 2021
@amezin amezin closed this as completed in 72b3be1 Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amezin