Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feture Request: Disabling Animation #50

Closed
uroybd opened this issue Jun 1, 2021 · 2 comments
Closed

Feture Request: Disabling Animation #50

uroybd opened this issue Jun 1, 2021 · 2 comments

Comments

@uroybd
Copy link

uroybd commented Jun 1, 2021

Hi,

An option to disabling show/hide animation altogether would be nice. Can it be implemented?
@amezin
Copy link
Member

amezin commented Jun 3, 2021

I don't know. Main.wm.skipNextEffect() should be called before the animation is set up. But override_[un]map_animation() are called after Shell's handlers for global.window_manager.map/destroy, i. e. default animations are started already. And calling skipNextEffect() from other signal handlers won't be reliable - will probably cancel unrelated animations

amezin added a commit that referenced this issue Jul 11, 2021
@amezin
extension: allow disabling window animation
106c5dc 
#50
amezin added a commit that referenced this issue Jul 11, 2021
@amezin
extension: improve animation disabling
d1edce1 
Now everything should be handled by skipNextEffect(), .remove_all_transitions()
don't seem to be necessary anymore.

#50
@amezin
Copy link
Member

amezin commented Jul 11, 2021

Implemented in https://github.com/amezin/gnome-shell-extension-ddterm/releases/tag/v20

@amezin amezin closed this as completed Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amezin @uroybd