-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support using colors from gnome terminal #53
Conversation
Can this be just a button in preferences dialog (i. e. "Copy settings from GNOME Terminal")? Unchecking the checkbox won't revert settings to the old values, as far as I can tell. Continuous sync may look cool, but is it actually useful? How frequent do you change colors in GNOME Terminal? |
6f4fe5b
to
36aae7a
Compare
You're right, I rarely change colors profile. I added the "Copy profile from GNOME Terminal" button at the bottom of the colors panel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything except logError()
s looks good.
Would be nice if it was possible to select the profile to import (button with a popup menu?) - but it is not a requirement.
e6575b4
to
38e677f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only 2 cosmetic changes are necessary, and then I'll merge it. Also, please squash commits into one (I can do it during merge, but your signature will probably be lost this way). Thank you!
38e677f
to
32be055
Compare
Since a lot of Gnome Shell users use Gnome Terminal, I think it is useful to sync with the color profile of Gnome Terminal.
upload.mp4