-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shortcuts for height and opacity #72
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, the implementation is correct. Please fix setting and action names, and try to get rid of code duplication.
After that:
- Please don't change package-lock.json
- Squash all commits into one
Almost done, but it seems there are errors that's appearing now:
This appears everytime the hotkey is used to increase/decrease the size (silent on transparency changes). |
You may ignore these warnings for now. Most likely your code isn't responsible for them. Do they appear if you open preferences and drag the "Window size" slider? |
Yes, I will ignore them. One final issue I've noticed is that changes to
I believe this is a result of this line. I don't think there is any reason for this? @amezin I've removed this condition to fix the behavior. Let me know if this is incorrect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me so far.
8e8176f
to
12a21e6
Compare
ccb7e46
to
7096fd8
Compare
Not sure about the test for gnome-wayland-nested-dual-monitor - is there something I can do @amezin? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If window-maximize
is true
, resizing should start from 1.0
.
- Maximize the window (F11 by default)
- Try to decrease its height.
It will resize to the original (unmaximized) size minus HEIGHT_MOD
.
IMO it should resize to 1.0 - HEIGHT_MOD
instead.
No, the test failure is unrelated to your changes. Tests rely on various timeouts too much, and some configurations thus fail from time to time. |
b33c9f3
to
8ffcd7d
Compare
Default keybindings for increasing/decreasing size are take from Guake, opacity bindings are unset.
This would close #70.