Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gnome-shell 41.x compatibility #83

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Add gnome-shell 41.x compatibility #83

merged 1 commit into from
Sep 29, 2021

Conversation

halfa
Copy link
Contributor

@halfa halfa commented Sep 29, 2021

Tested on a fedora 35 workstation (beta) by editing manually the
metadata file at
~/.local/share/gnome-shell/extensions/ddterm@amezin.github.com/metadata.json.

The extension seems to be working fine.

  • the shell is showing
  • the setting windows open

Handful of warnings in the logs when I trigger the shell:

$ journalctl -fe /usr/bin/gnome-shell
sept. 29 19:44:44 hostname gnome-shell[1941]: meta_window_set_stack_position_no_sync: assertion 'window->stack_position >= 0' failed
sept. 29 19:44:44 hostname gnome-shell[1941]: meta_window_set_stack_position_no_sync: assertion 'window->stack_position >= 0' failed

$ gnome-shell --version
GNOME Shell 41.0

Close #77 (if the warning is harmless).

Tested on a fedora 35 workstation (beta) by editing manually the
metadata file at
`~/.local/share/gnome-shell/extensions/ddterm@amezin.github.com/metadata.json`.

The extension seems to be working fine.
- the shell is showing
- the setting windows open

Handful of warnings in the logs when I trigger the shell:
```
$ journalctl -fe /usr/bin/gnome-shell
sept. 29 19:44:44 hostname gnome-shell[1941]: meta_window_set_stack_position_no_sync: assertion 'window->stack_position >= 0' failed
sept. 29 19:44:44 hostname gnome-shell[1941]: meta_window_set_stack_position_no_sync: assertion 'window->stack_position >= 0' failed

$ gnome-shell --version
GNOME Shell 41.0
```

Close #77 (if the warning is harmless).
@amezin
Copy link
Member

amezin commented Sep 29, 2021

The warning appears on previous GNOME versions too.

However, for me window animations don't work correctly on Fedora 35. On both X.org and Wayland. Hide animation seems to be fine (not sure), but show animation is the default one, even if "Override default window animations" is enabled. #84

Although this isn't a critical issue

@amezin amezin merged commit 1282c1e into ddterm:master Sep 29, 2021
@halfa halfa deleted the gnome-shell-41-compatibility branch September 30, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated on GNOME 41.beta.0
2 participants