MUI_Request doesn't show icons

[afalkenhahn]

Seems like in newer versions the MUIV_Requester_Image_XXX flags are ignored. See here: https://forums.hollywood-mal.com/viewtopic.php?p=16944#p16944

In my MUI version (5.0-2017R1) it's working fine but in newer versions it seems to be broken.

[tboeckel]

I just tried this myself on OS3 and all icons are perfectly shown, both default icons (depending on the number of buttons) as well as custom icons (i.e. MUIV_Requester_Image_InsertDisk).
All the requester related code has not been touched within the last years, except bumping copyright years in comments.

The last real changes were these:
`2018-08-20 Thore Böckelmann tboeckel@gmx.de

• masterreq.c: remove underscores and other MUI specific characters from the
  buttons string when falling back to EasyRequest(). This refs Is there any way to force WFLG_RMBTRAP while using a menu at the same time? #330.
• masterreq.c, mastertext.c: use a plain text version of the body text passed
  to MUI_RequestA() when falling back to EasyRequest(). This refs Is there any way to force WFLG_RMBTRAP while using a menu at the same time? #330.

2018-02-13 Thore Böckelmann tboeckel@gmx.de

• masterreq.c: MUI_Request() will automatically wrap the body text at word
  boundaries. This allows to use arbitrary long single line body texts without
  having to fear that MUI will automatically adapt the font sizes to squeeze
  the GUI onto the screen, which eventually may fail if the strings are too
  long. Currently the text will be wrapped to take not more than half of the
  screen's width, but at least 400 pixels. This closes #370.`

But these changes only affect handling of the text, the handling of the icons has not been touched at all.

I cannot tell what Rapagui or Hollywood do between user code and MUI.

[afalkenhahn]

Actually, it works for me, but it doesn't work for a user. See here: https://forums.hollywood-mal.com/viewtopic.php?p=17083#p17083

Could it be some misconfiguration of MUI on the user side or a certain theme the user is using that's causing this?

[tboeckel]

On AmigaOS3 embedded images are used, these should work always, unless bzip2.library is available to uncompress the data.

On AmigaOS4 external images are used. If these are missing then of course no image can be displayed.
These image files must exist:

• SYS:Prefs/Presets/Requester/Info
• SYS:Prefs/Presets/Requester/Question
• SYS:Prefs/Presets/Requester/Warning
• SYS:Prefs/Presets/Requester/Error
• SYS:Prefs/Presets/Requester/InsertDisk

[afalkenhahn]

Ok, so found out what the issue is here: The reason why icons aren't shown is probably related to the fact that NULL is passed for app and win. Check the attached example, it doesn't show the icon.
main.txt

[tboeckel]

Without a valid application object MUI will call EasyRequest() instead of creating a MUI window. Of course there will be no icons if the OS does not support this in EasyRequest(). Pass a valid application object and the icons will be shown.

[afalkenhahn]

Why don't you use requester.class on OS4 in that case? It would allow to show icons through the REQ_Image tag.