Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractNode.java:38-39: Implement and unit test Sequence node. S... #9

Closed
0pdd opened this issue Dec 30, 2016 · 5 comments
Closed

Comments

@0pdd
Copy link

0pdd commented Dec 30, 2016

The puzzle 7-2533d5cf in src/main/java/com/amihaiemil/camel/AbstractNode.java (lines 38-39) has to be resolved: Implement and unit test Sequence node. See specification: http://yaml.org/spec/1.2/spec.html#sequence//

The puzzle was created by amihaiemil on 30-Dec-16.

Estimate: 60 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code.

@amihaiemil
Copy link
Member

amihaiemil commented Jan 5, 2017

@dwkielman Please implement class Sequence which:

  • should extend AbstractNode
  • should encapsulate a Collection<AbstractNode>
  • should have a method named value() which returns the encapsulated collection

Also, add a unit test class for it and write unit tests (see ScalarTest as example)

Don't forget to apply the styling guidlines (most importantly, no TABs and lines no longer than 80 characters) - just make sure the build mvn clean install -Pcheckstyle passes after you make the changes. If you are not sure about a checkstyle error, just make the PR and I'll explain.

@amihaiemil
Copy link
Member

amihaiemil commented Jan 9, 2017

@dwkielman Please stop working on this (if you started anything).

I'll take this one - It's a basis stuff, I should have done it myself from the start. I want to spend some more time thinking about it. If we introduce a design bug in this stage, it will be a sad story later.

@dwkielman
Copy link

@amihaiemil I'll leave this one alone, if you have something else to assign me let me know and I can get to work on that one. Thanks for the heads up.

@amihaiemil
Copy link
Member

@dwkielman sure. And sorry for the inconvenience :D

@amihaiemil
Copy link
Member

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants