Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

32-bit error message is sometimes misleading #102

Closed
fagerbua opened this issue Oct 11, 2017 · 2 comments
Closed

32-bit error message is sometimes misleading #102

fagerbua opened this issue Oct 11, 2017 · 2 comments

Comments

@fagerbua
Copy link
Contributor

The changes in #46 makes the plugin fail when Flow doesn't run. That is clearly an improvement. But the error message is not always accurate: it complains about 32 bit even when the cause is something else — for example, the glibc version being too low (Flow issue #49), or the FLOW_BIN variable pointing to a binary that doesn't exist.

As a solution I would propose changing the error message to say simply that the plugin was unable to run Flow. If the 32-bit error is very common it might still be mentioned as a possible cause.

If you agree I could try to prepare a PR for this change.

@amilajack
Copy link
Owner

amilajack commented Oct 11, 2017

@fagerbua i agree with this. A PR would be welcome. Mentioning likely issues with why flow might not be running would be a nice improvement. Ex:

Flow could not be run. Common issues include
* running on 32-bit OS
* glibc not found (https://github.com/flowtype/flow-bin/issues/49)

@jdmota
Copy link
Collaborator

jdmota commented Oct 11, 2017

Sorry about that. Didn't know about those cases.

For the PR, you just need to change the message here:

function error32bit() {
return {
loc: 1,
message: "Flow does not support 32 bit OS's at the moment."
};
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants