Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broader flow-bin peer dependency range? #106

Closed
lydell opened this issue Oct 22, 2017 · 2 comments
Closed

Broader flow-bin peer dependency range? #106

lydell opened this issue Oct 22, 2017 · 2 comments

Comments

@lydell
Copy link
Contributor

lydell commented Oct 22, 2017

It feels like I always happen to use a non-compatible flow-bin version in my projects, so npm and yarn always warn me about this. Everything still works fine though.

It feels like the interface of the parts of flow-bin that eslint-plugin-flowtype-errors actually use has been stable for a long time, and does not seem to change soon.

Could we change the peer dependency to something like this to avoid unnecessary warnings from npm and yarn?

"flow-bin": ">=0.50.0"

(Where 0.50.0 is some known compatible version reasonably far back in the past.)

@amilajack
Copy link
Owner

The issue with this is that we test against later flow versions. Cant guarantee that the plugin will work with older versions. I would recommend updating your flow version

@lydell
Copy link
Contributor Author

lydell commented Oct 22, 2017

I understand that you can't guarantee that it will work, but in practice things have never broken for me. Of course I want to use the latest Flow version, but upgrading usually means that new errors are found, so you can't just do it in 5 minutes. And when I do find the time, I probably have upgraded to a newer version than eslint-plugin-flowtype-errors specifies so I get the peer dependency warning anyway...

The peer dependency on ESLint is specified like this:

"eslint": ">=4.0.0",

Why is that different?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants