Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting errors on TravisCI #123

Open
vincentaudebert opened this issue Jun 3, 2018 · 6 comments
Open

Getting errors on TravisCI #123

vincentaudebert opened this issue Jun 3, 2018 · 6 comments

Comments

@vincentaudebert
Copy link

Hi,

I'm getting the following errors on my TravisCI but it doesn't happen on my local machine.
(Note this could be related to #41)

screen shot 2018-06-04 at 12 20 13 am

Here is my eslint config:

{
  "parser": "babel-eslint",
  "extends": [
    "airbnb",
    "plugin:react/recommended",
    "plugin:flowtype/recommended",
    "prettier",
    "prettier/react",
    "prettier/flowtype"
  ],
  "plugins": ["react", "prettier", "flowtype", "flowtype-errors"],
  "rules": {
    "jsx-a11y/anchor-is-valid": [
      "error",
      {
        "components": ["Link"],
        "specialLink": ["to"],
        "aspects": ["noHref", "invalidHref", "preferButton"]
      }
    ],
    "prettier/prettier": [
      "error",
      {
        "singleQuote": true,
        "trailingComma": "es5",
        "tabWidth": 2
      }
    ],
    "flowtype-errors/show-errors": 2,
    "no-warning-comments": [
      1,
      { "terms": ["todo", "fixme", "xxx"], "location": "start" }
    ],
    "react/sort-comp": [0],
    "react/no-unescaped-entities": [0],
    "react/jsx-boolean-value": [0],
    "react/jsx-filename-extension": [1, { "extensions": [".js", ".jsx"] }],
    "react/default-props-match-prop-types": "off",
    "jsx-a11y/no-static-element-interactions": [0]
  },
  "env": {
    "es6": true,
    "browser": true
  }
}

And my flow config:

[ignore]
.*/build/.*
.*\.json

[include]

[libs]

[lints]

[options]

Any idea what could be wrong?

Thank you.

@jdmota
Copy link
Collaborator

jdmota commented Jun 4, 2018

Can you try to run flow directly in CI? Without using eslint-plugin-flowtype-errors? Thanks

@vincentaudebert
Copy link
Author

@jdmota my flow task works fine yes. Does your comment mean I can't use eslint-plugin-flowtype-errors with Travis?

@vincentaudebert
Copy link
Author

I moved to CircleCI and the error is gone. I'll stay there and ditch TravisCI. Thanks. I close this issue but feel free to comment if you have a fix.

@jdmota
Copy link
Collaborator

jdmota commented Jun 4, 2018

image

That is weird. Not sure why we output "Cannot resolve module" but flow passes with no errors...

I think it is worth to investigate.

@jdmota jdmota reopened this Jun 4, 2018
@vincentaudebert
Copy link
Author

You might have found the details already but just in case
My repo is github.com/vincentaudebert/vatweb
And the travis config I was using is the following: https://github.com/vincentaudebert/vatweb/blob/5c67f7bacd320214f30b3f616a2937738fdf5a0b/.travis.yml

@BrunoBernardino
Copy link

I'm having a similar problem at with https://github.com/BrunoBernardino/snailjs now. I've tried forcing the relative path and the yarn version. Locally it's all good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants