Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin throws errors when flow detects no errors #23

Closed
Adjective-Object opened this issue Oct 2, 2016 · 2 comments
Closed

plugin throws errors when flow detects no errors #23

Adjective-Object opened this issue Oct 2, 2016 · 2 comments

Comments

@Adjective-Object
Copy link

on collect.js line 114

  return output.length
    ? filter(output)
    : true;

Because the stdout of collect.js is parsed by index.js, which then immediately runs it through JSON.parse, and then filter, which does not exist on booleans.

Suggest changing the false clause of the ternary to [] to correct this.

@Adjective-Object Adjective-Object changed the title plugin throws erros when flow detects no errors plugin throws errors when flow detects no errors Oct 2, 2016
@Adjective-Object
Copy link
Author

Alternatively,

return output

@amilajack
Copy link
Owner

Try updating to 1.3.0 and let me know if the issue persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants