Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to disable enforce-min-coverage for a file #96

Closed
Hypnosphi opened this issue Aug 16, 2017 · 6 comments
Closed

How to disable enforce-min-coverage for a file #96

Hypnosphi opened this issue Aug 16, 2017 · 6 comments

Comments

@Hypnosphi
Copy link

I have file for which I don't need to enforce minimal coverage. Unfortunately, this doesn't seem to work:

/* eslint-disable flowtype-errors/enforce-min-coverage */
@jdmota
Copy link
Collaborator

jdmota commented Aug 18, 2017

Have you tried

/* eslint "flowtype-errors/enforce-min-coverage": "off" */ ?

https://eslint.org/docs/user-guide/configuring.html#configuring-rules

@Hypnosphi
Copy link
Author

This one works, thanks. I guess, eslint-disable doesn't because it's a per-file rule?

@jdmota
Copy link
Collaborator

jdmota commented Aug 18, 2017

For plugins, I think you have to put quotes "flowtype-errors/enforce-min-coverage"

/* eslint-disable "flowtype-errors/enforce-min-coverage" */ should work too, not sure tho.

@jdmota
Copy link
Collaborator

jdmota commented Aug 18, 2017

I believe it has nothing to do with the rule, but instead, how eslint reads those comments.

@Hypnosphi
Copy link
Author

/* eslint-disable "flowtype-errors/enforce-min-coverage" */ should work too, not sure tho.

No it doesn't

@amilajack
Copy link
Owner

@Hypnosphi please add a PR with a test case. I cant reproduce this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants