-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python3 support] Investigate what is needed #25
Comments
This reminds me that |
I'm not sure what's the best approach for Go. I guess that ideally you would want a Go implementation of zfec, but time wise that is probably not ideal. As for Python I just noticed that there was already a PR for Python 3 support (tahoe-lafs/zfec#4) and it is not so big. So I would prefer helping with getting this PR through, assuming that there's not too much work left to be done 😄 ! |
UPDATE: Python 3 only port is under branch https://github.com/sbellem/HoneyBadgerBFT/tree/python3-port All tests are passing, and the coverage is at 79%. Things that are left to do (see Porting Python 2 Code to Python 3 for help):
|
This is fantastic work, thanks for being so systematic and looking into the zfec dependency especially. I appreciate that you set up the dependency link in the meantime to your own fork while also nudging them to merge the pull request! I would be happy to adopt python3 even without maintaining python2 compatibility for this. |
Thanks to @tpltnt, pyutil now supports Python 3! This is a step forward for the zfec PR: tahoe-lafs/zfec#4 (comment). |
|
Closing as it was handled in initc3/HoneyBadgerBFT-Python#3 |
Given the various specialized dependencies, especially the cryptographic ones, this issue is simply concerned with evaluating how feasible it would be to port HoneyBadgerBFT to Python 3 in a reasonable time frame.
The result of the evaluation will be documented here in this issue.
blockers
UPDATE: No more blockers.
zfec
now supports Python 3 -- PR tahoe-lafs/zfec#4 was merged.zfec
does not support Python 3 at the moment (related issue: tahoe-lafs/zfec#1)There's a PR 😄 --> tahoe-lafs/zfec#4 !Dependencies
gevent
gmpy2
pysocks
zfec
Charm-Crypto
ecdsa
gipc
pycrypto
Notes
Some details to watch out for.
charm-crypto
The latest
charm-crypto
cannot be installed simply withpip
as there is an error when setting config values. This can be worked around by cloning the repo and performing the configuration to create a config file and running make, and then pip installing. So not a big deal, but inconvenient.pycrypto
The text was updated successfully, but these errors were encountered: