Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used Sqlalchemy_utils types #148

Closed
1 task done
colin99d opened this issue May 9, 2022 · 2 comments · Fixed by #150
Closed
1 task done

Used Sqlalchemy_utils types #148

colin99d opened this issue May 9, 2022 · 2 comments · Fixed by #150
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@colin99d
Copy link
Contributor

colin99d commented May 9, 2022

Checklist

  • There are no similar issues or pull requests for this yet.

Is your feature related to a problem? Please describe.

I want to be able to use model types provided by sqlalchemy_utils such as EmailType, IPAddressType, and UUIDType.

Describe the solution you would like.

I would like the admin page to work without crashing when they are used (just treating them all as strings would work fine for me).

Describe alternatives you considered

I could convert them all to strings in my model, but that would take away a lot of functionality.

Additional context

No response

@aminalaee aminalaee added enhancement New feature or request good first issue Good for newcomers labels May 10, 2022
@aminalaee
Copy link
Owner

Hi,

Yes I think that's been requested before, feel free to create a PR for it if you're interested.
The change is straightforward and needs to be added here: https://github.com/aminalaee/sqladmin/blob/main/sqladmin/forms.py#L318

@colin99d
Copy link
Contributor Author

Will do this once I get some down time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants