Many to many field setup error #152
Comments
|
Hey can you provide an example for this? I think basic M2M should be ok now. |
|
Closing this as this is not valid anymore. |
|
I am currently seeing this issue. Why is it no longer a valid issue? |
|
Please post a full example and trace of what is wrong. |
|
Some edits made to simplify and hide privileged data, but this should be enough to cause the issue. main.py from fastapi import FastAPI
from sqladmin import Admin
from .admin import (
InstitutionAdmin,
TrajectoryModelAdmin,
UserAdmin,
)
from .databases import engine
app = FastAPI()
admin = Admin(app, engine)
admin.register_model(InstitutionAdmin)
admin.register_model(UserAdmin)
admin.register_model(TrajectoryModelAdmin)databases.py import databases
from sqlalchemy.ext.asyncio import AsyncSession, create_async_engine
from sqlalchemy.orm import sessionmaker
DATABASE_URL = "postgresql+asyncpg://postgres:password@db/postgres"
database = databases.Database(DATABASE_URL)
engine = create_async_engine(DATABASE_URL)
AsyncSessionLocal = sessionmaker(
autocommit=False,
autoflush=False,
expire_on_commit=False,
bind=engine,
class_=AsyncSession,
)admin.py from fastapi import Request
from sqladmin import ModelAdmin
from .models import Institution, TrajectoryModel, User
class InstitutionAdmin(ModelAdmin, model=Institution):
column_list = [Institution.name, Institution.uuid]
column_details_list = [Institution.name, Institution.users]
form_columns = [Institution.name]
class UserAdmin(ModelAdmin, model=User):
column_list = [User.username, User.uuid]
column_details_list = [
User.institution,
User.username,
User.first_name,
User.last_name,
]
form_columns = [
User.institution,
User.username,
User.first_name,
User.last_name,
User.password_hash,
]
class TrajectoryModelAdmin(ModelAdmin, model=TrajectoryModel):
column_list = [TrajectoryModel.name, TrajectoryModel.uuid]
form_columns = [
TrajectoryModel.institution,
TrajectoryModel.name,
TrajectoryModel.json_data,
]models.py import datetime
import uuid as uuid_
from sqlalchemy import TIMESTAMP, Column, ForeignKey, String, UniqueConstraint
from sqlalchemy.dialects.postgresql import JSONB, UUID
from sqlalchemy.orm import Mapped, declarative_base, relationship
from sqlalchemy.sql.functions import current_timestamp
Base = declarative_base()
class Institution(Base):
__tablename__ = "institutions"
uuid: Mapped[uuid_.UUID] = Column(
UUID(as_uuid=True), primary_key=True, default=uuid_.uuid4
)
name: Mapped[str] = Column(String(), nullable=False, unique=True)
users: Mapped[list["User"]] = relationship(
"User",
back_populates="institution",
cascade="all, delete",
passive_deletes=True,
)
trajectory_models: Mapped[list["TrajectoryModel"]] = relationship(
"TrajectoryModel",
back_populates="institution",
cascade="all, delete",
passive_deletes=True,
)
def __repr__(self):
return f"{self.name} ({self.uuid})"
class User(Base):
__tablename__ = "users"
uuid: Mapped[uuid_.UUID] = Column(
UUID(as_uuid=True), primary_key=True, default=uuid_.uuid4
)
institutions_uuid: Mapped[uuid_.UUID] = Column(
UUID(as_uuid=True),
ForeignKey("institutions.uuid", ondelete="CASCADE"),
nullable=False,
)
institution: Mapped[Institution] = relationship(Institution, back_populates="users")
username: Mapped[str] = Column(String(), nullable=False, unique=True)
first_name: Mapped[str] = Column(String(), nullable=False)
last_name: Mapped[str] = Column(String(), nullable=False)
password_hash: Mapped[str | None] = Column(String(), nullable=True)
def __repr__(self):
return f"{self.username} ({self.uuid})"
class TrajectoryModel(Base):
__tablename__ = "trajectorymodels"
__table_args__ = (
UniqueConstraint(
"name",
"institutions_uuid",
name="trajectorymodels__uq__name__institutions_uuid",
),
)
uuid: Mapped[uuid_.UUID] = Column(
UUID(as_uuid=True), primary_key=True, default=uuid_.uuid4
)
name: Mapped[str] = Column(String(), nullable=False)
institutions_uuid: Mapped[uuid_.UUID] = Column(
UUID(as_uuid=True),
ForeignKey("institutions.uuid", ondelete="CASCADE"),
nullable=False,
)
institution: Mapped[Institution] = relationship(
Institution, back_populates="trajectory_models"
)
json_data: Mapped[dict] = Column(
"data", JSONB(none_as_null=True), default=dict, nullable=False
)
date_created: Mapped[datetime.datetime] = Column(
TIMESTAMP(timezone=True),
nullable=False,
server_default=current_timestamp(),
default=lambda: datetime.datetime.now(datetime.timezone.utc),
)
last_modified: Mapped[datetime.datetime] = Column(
TIMESTAMP(timezone=True),
nullable=False,
server_default=current_timestamp(),
default=lambda: datetime.datetime.now(datetime.timezone.utc),
onupdate=current_timestamp(),
)
def __repr__(self):
return f"{self.name} ({self.uuid})"pyproject.toml [tool.poetry.dependencies]
fastapi = "^0.78.0"
psycopg2 = "^2.9"
python = ">=3.10,<3.11"
databases = { version = "*", extras = ["asyncpg"] }
SQLAlchemy = { version = ">=1.3.0", extras = ["asyncio"] }
alembic = { version = "^1.8.0", extras = ["tz"] }
sqladmin = "^0.1.12"DB schema (edited down from CREATE TABLE institutions (
uuid uuid NOT NULL PRIMARY KEY,
name character varying NOT NULL
);
CREATE TABLE trajectorymodels (
uuid uuid NOT NULL PRIMARY KEY,
name character varying NOT NULL,
institutions_uuid uuid NOT NULL,
data jsonb NOT NULL,
date_created timestamp with time zone DEFAULT CURRENT_TIMESTAMP NOT NULL,
last_modified timestamp with time zone DEFAULT CURRENT_TIMESTAMP NOT NULL
);
CREATE TABLE users (
uuid uuid NOT NULL PRIMARY KEY,
institutions_uuid uuid NOT NULL,
first_name character varying NOT NULL,
last_name character varying NOT NULL,
username character varying NOT NULL,
password_hash character varying
);
ALTER TABLE institutions
ADD CONSTRAINT institutions_name_key UNIQUE (name);
ALTER TABLE users
ADD CONSTRAINT users_username_key UNIQUE (username);
ALTER TABLE users
ADD CONSTRAINT users_institutions_uuid_fkey FOREIGN KEY (institutions_uuid) REFERENCES institutions(uuid) ON DELETE CASCADE;
ALTER TABLE trajectorymodels
ADD CONSTRAINT trajectorymodels__uq__name__institutions_uuid UNIQUE (name, institutions_uuid);
ALTER TABLE trajectorymodels
ADD CONSTRAINT trajectorymodels_institutions_uuid_fkey FOREIGN KEY (institutions_uuid) REFERENCES institutions(uuid) ON DELETE CASCADE;Creating a new user works, but attempting to save after an edit causes this stacktrace: |
|
@murrple-1 Have you also tried this on latest code on git main branch? |
|
Yes, the top of Looking forward to the next release then :) |
|
Vsrsion 0.2.0 is released so closing this :) |
Hi, I think example above not even real many-to-many relationship. But you write that it possible, can you give an example for these: class Badge(Base):
__tablename__ = "badge"
id: Mapped[int] = mapped_column(BigInteger, primary_key=True, autoincrement=True, nullable=False)
name: Mapped[str] = mapped_column(Text, unique=True, nullable=False)
description: Mapped[str] = mapped_column(Text, nullable=False)
class VaultBadge(Base):
__tablename__ = "vault_badge"
id: Mapped[int] = mapped_column(BigInteger, primary_key=True, autoincrement=True, nullable=False)
vault_id: Mapped[int] = mapped_column(ForeignKey("vault.id"))
badge_id: Mapped[int] = mapped_column(ForeignKey("badge.id"))
badge: Mapped[Badge] = relationship()
class Vault(Base):
__tablename__ = "vault"
id: Mapped[int] = mapped_column(BigInteger, primary_key=True, autoincrement=True, nullable=False)
name: Mapped[str] = mapped_column(Text, unique=True, nullable=False)
description: Mapped[str] = mapped_column(Text, nullable=False)
badges: Mapped[List[VaultBadge]] = relationship()and I have VaultAdmin: class VaultAdmin(ModelView, model=Vault):
page_size = 50
page_size_options = [50, 100, 200]In VaultAdmin I want see all badges names that I have in list format, how to achieve this? Path like Vault.badges.badge.name |
|
@aminalaee ^^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Checklist
master.Describe the bug
I am trying to update m2m field in form but i am getting error
"sqlalchemy.exc.InvalidRequestError: Can't attach instance another instance with key is already present in this session"Steps to reproduce the bug
No response
Expected behavior
No response
Actual behavior
No response
Debugging material
No response
Environment
Macos , python 3.9
Additional context
No response
The text was updated successfully, but these errors were encountered: