New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] sqlalchemy_utils for ColorType, JSONType, PasswordType, ScalarListType #217
Conversation
Any updates? |
Yeah, was hoping for your thoughts on ChoiceType, CountryType, CurrencyType, LocalType and WeekDaysType. Then I was going to move on from there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
sqladmin/forms.py
Outdated
@converts("sqlalchemy_utils.types.choice.ChoiceType") | ||
def conv_choice( | ||
self, model: type, prop: ColumnProperty, kwargs: Dict[str, Any] | ||
) -> UnboundField: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey man, I did my best to implement choices like you suggested but ran into errors. Any way I could get some help? |
@colin99d Thanks, I think the pipeline is failing for the And also please rename the PR so it's clear what types are added. |
So I should just exclude choices for now? |
Yes please. |
Are you still interested in updating this? |
Sorry kinda spaced it! Do you just need me to get CI to pass? |
This PR attempts to add the remaining sqlachemy_utils data types. Complete list here: https://sqlalchemy-utils.readthedocs.io/en/latest/data_types.html#module-sqlalchemy_utils.types.choice. Notes for each one appear below: